Persisters should error if you try to save something which is gone now, but used to be persisted. #867
Conversation
|
Converted to draft because there's an issue with the buffered persister. |
|
There's a fundamental issue in that in the case of a CompositePersister, the second persister may not be internally consistent. Like if I'm doing a full reindex it doesn't matter if that resource isn't in Solr - I brought it over from postgres. |
tpendragon
force-pushed
the
837-persisters-should-error
branch
from
931cb2e to
a845253
Compare
refs #837 Co-authored-by: Ayse Durmaz <[email protected]>
refs #837 Co-authored-by: Ayse Durmaz <[email protected]>
tpendragon
force-pushed
the
837-persisters-should-error
branch
from
a845253 to
d81d2ae
Compare
| @@ -24,6 +24,12 @@ def delete(resource:) | |||
| @deletes << resource | |||
| super | |||
| end | |||
|
|
|||
| # A buffered memory persister can save anything, it doesn't have to hold | |||
There was a problem hiding this comment.
Because it doesn't actually persist anything directly; proxies to other persisters.
| @@ -16,12 +16,15 @@ def initialize(adapter) | |||
|
|
|||
| # Save a single resource. | |||
| # @param resource [Valkyrie::Resource] The resource to save. | |||
| # @param external_resource [Boolean] Whether the resource to be saved comes | |||
| # from a different metadata store. Allows a resource to be saved even if | |||
| # it's not already in the store. | |||
There was a problem hiding this comment.
Add example use case, "e.g. when building a new solr index"
There was a problem hiding this comment.
or migrating to a new data store?
There was a problem hiding this comment.
@tpendragon add an example use case?
Upgrades Valkyrie to this branch: samvera/valkyrie#867 See #4672 Work towards #4174
|
We've been running this for a couple weeks now with no badness. I think we can merge it - but this will probably mean 3.0.0.beta1 or something. |
| @@ -16,12 +16,15 @@ def initialize(adapter) | |||
|
|
|||
| # Save a single resource. | |||
| # @param resource [Valkyrie::Resource] The resource to save. | |||
| # @param external_resource [Boolean] Whether the resource to be saved comes | |||
| # from a different metadata store. Allows a resource to be saved even if | |||
| # it's not already in the store. | |||
There was a problem hiding this comment.
@tpendragon add an example use case?
|
@hackartisan Take another look? |
Closes #837