Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisters should error if you try to save something which is gone now, but used to be persisted. #867

Merged
merged 15 commits into from
Oct 15, 2021
Merged

Persisters should error if you try to save something which is gone now, but used to be persisted. #867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d06ca96
Add a shared persister spec for saving a deleted resource
hackartisan Oct 22, 2020
e85a12a
Raise ObjectNotFound on save for memory adapter
hackartisan Oct 22, 2020
a40b215
Fix Fedora persister.
tpendragon Oct 29, 2020
122e8e3
Fix Postgres Persister
tpendragon Oct 29, 2020
05800c3
Fix Composite Persister.
tpendragon Oct 29, 2020
fd7e0d0
Fix Solr.
tpendragon Jul 28, 2021
f5331bf
Fix BufferedPersister.
tpendragon Jul 28, 2021
fc16567
Add failing test for CompositePersister.
tpendragon Jul 28, 2021
8c9e3ba
Add a parameter to save.
tpendragon Jul 28, 2021
0afbbca
CompositePersister uses new #external_resource
tpendragon Jul 28, 2021
928f423
Rubocop.
tpendragon Jul 28, 2021
e502152
Fix.
tpendragon Jul 28, 2021
d81d2ae
Don't reset new record state.
tpendragon Jul 28, 2021
43042a0
Add memo-ization of persister.
tpendragon Sep 14, 2021
265ccd5
Add more to the external_resource comment.
tpendragon Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/valkyrie/persistence/delete_tracking_buffer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ def delete(resource:)
@deletes << resource
super
end

# A buffered memory persister can save anything, it doesn't have to hold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it doesn't actually persist anything directly; proxies to other persisters.

# a consistent internal state.
def valid_for_save?(_)
true
end
end
end
end
10 changes: 10 additions & 0 deletions spec/valkyrie/persistence/buffered_persister_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,15 @@ class Resource < Valkyrie::Resource
end
expect(buffer.query_service.find_all.length).to eq 1
end
it "can handle saving an object which was previously saved" do
buffer = nil
resource = Resource.new
output = adapter.persister.save(resource: resource)
persister.with_buffer do |inner_persister, memory_buffer|
inner_persister.save(resource: output)
buffer = memory_buffer
end
expect(buffer.query_service.find_all.length).to eq 1
end
end
end