Apply stash #1
Open
Apply stash #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebid#1020) * Use POST, preserve original user agent and user ip in the headers * Change test to stub for post * cleanup * actually return modified headers
…nce event could contain non-serializable objects (prebid#1028)
* Add http api for fetching accounts * Replace ObjectNode with Account type in HttpAccountResponse model * Fixes after review
* Add metrics to track settings cache population if it is enabled * Add metrics to track account cache hits and misses
…y stopped between integration tests (prebid#1106)
* Add support for multi-imp requests in ttx bidder * Updated position of request ext creating * Fixes after review * Add addProperties instead of constructor creating * Remove changes related to core
mefjush
reviewed
Jan 29, 2021
| getIfaParameter(request.getDevice())); | ||
| private AdheseRequestBody buildBody(BidRequest request, ExtImpAdhese extImpAdhese) { | ||
| AdheseRequestBody body = new AdheseRequestBody(); | ||
| body.slots.add(AdheseRequestBody.Slot.create(getSlotParameter(extImpAdhese))); |
There was a problem hiding this comment.
is only one slot per request supported here?
…meters (prebid#976) * Moved bidder parameters from imp.ext to imp.ext.prebid.bidder before proceeding with an auction * Merge bidder parameters instead of replacing whole object * Adjust bid request validation to look into new location of bidder parameters * Update core exchange logic to look for bidder parameters in new location * Update stored response processing to look for bidders in new location * Update Rubicon bidder to look for cpmoverride in new location * Do not pass empty prebid sub-ext to bidders * Fix integration tests after moving bidder parameters to a new place * Tidy up * Update references to imp.ext.<bidder> with a new location imp.ext.prebid.bidder.<bidder>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.