Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For release #70

Merged
merged 348 commits into from
May 18, 2023
Merged

For release #70

merged 348 commits into from
May 18, 2023

Conversation

priyanka-surana
Copy link
Contributor

Please comment, request changes, and approve but DO NOT MERGE.

muffato and others added 30 commits February 2, 2023 00:11
@priyanka-surana priyanka-surana added this to the 1.0.0 milestone May 16, 2023
@priyanka-surana priyanka-surana self-assigned this May 16, 2023
@github-actions
Copy link

github-actions bot commented May 16, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 52d7d3d

+| ✅ 130 tests passed       |+
#| ❔  15 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: '0.1.0'
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-18 18:26:44

Copy link
Collaborator

@alxndrdiaz alxndrdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka-surana Just found out that MultiQC throws an error while running the small test (not sure if you get the same error as well):

Command error:
  ##### Flat plots will instead be plotted as interactive #####
  |    custom_content | sanger-tol-blobtoolkit-methods-description: Found 1 sample (html)
  |    custom_content | software_versions: Found 1 sample (html)
  |    custom_content | sanger-tol-blobtoolkit-summary: Found 1 sample (html)
  |          mosdepth | Found 4 reports
  ╭──────────────── Oops! The 'mosdepth' MultiQC module broke... ────────────────╮
  │ Please copy this log and report it at                                        │
  │ https://github.com/ewels/MultiQC/issues                                      │
  │ Please attach a file that triggers the error. The last file found was:       │
  │ ./5/mMelMel3_T1.mosdepth.region.dist.txt                                     │
  │                                                                              │
  │ Traceback (most recent call last):                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/plots/linegraph.py", │
  │     return get_template_mod().linegraph(plotdata, pconfig)                   │
  │            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                      │
  │ AttributeError: module 'multiqc.templates.default' has no attribute 'linegra │
  │                                                                              │
  │ During handling of the above exception, another exception occurred:          │
  │                                                                              │
  │ Traceback (most recent call last):                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/multiqc.py", line 65 │
  │     output = mod()                                                           │
  │              ^^^^^                                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/modules/mosdepth/mos │
  │     plot=linegraph.plot(                                                     │
  │          ^^^^^^^^^^^^^^^                                                     │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/plots/linegraph.py", │
  │     matplotlib_linegraph(plotdata, pconfig)                                  │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/plots/linegraph.py", │
  │     fig = plt.figure(figsize=(14, plt_height), frameon=False)                │
  │           ^^^                                                                │
  │ NameError: name 'plt' is not defined                                         │
  │                                                                              │
  ╰──────────────────────────────────────────────────────────────────────────────╯ 

@priyanka-surana
Copy link
Contributor Author

@priyanka-surana Just found out that MultiQC throws an error while running the small test (not sure if you get the same error as well):

Unfortunately I am unable to replicate this error. Tried with both Nextflow version 22.x and 23.x. I am guessing this was mostly due to the disk quota error you saw.

@priyanka-surana priyanka-surana mentioned this pull request May 17, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@priyanka-surana priyanka-surana merged commit ffb4a70 into main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants