Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update images #71

Merged
merged 1 commit into from
May 17, 2023
Merged

update images #71

merged 1 commit into from
May 17, 2023

Conversation

priyanka-surana
Copy link
Contributor

This PR updates the images module and its integration in the subworkflow to create the relevant plots

@priyanka-surana priyanka-surana requested a review from muffato May 17, 2023 09:45
@priyanka-surana priyanka-surana self-assigned this May 17, 2023
@priyanka-surana priyanka-surana added the enhancement Improvement of the existing features label May 17, 2023
@priyanka-surana priyanka-surana added this to the 1.0.0 milestone May 17, 2023
@priyanka-surana
Copy link
Contributor Author

priyanka-surana commented May 17, 2023 •
edited
Loading

@muffato Can we merge this before you approve PR #70? Thanks!

This also removes the extra test.png.

@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 80b94b2

+| ✅ 131 tests passed       |+
#| ❔  15 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-17 09:46:46

@priyanka-surana priyanka-surana merged commit 7e98cf9 into dev May 17, 2023
@priyanka-surana priyanka-surana deleted the images branch May 17, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffato muffato muffato approved these changes

Assignees

@priyanka-surana priyanka-surana

Labels
enhancement Improvement of the existing features
Projects
BlobToolKit Nextflow Pipeline
Status: Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@priyanka-surana @muffato