collection: Ensure compatibility with Ansible 2.16.1

[berndfinger]

No description provided.

[berndfinger]

See also:

• The conditional check 'XX <= 15' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated. #555 - relates to:
  • https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_9.html#playbook - relates to:
    • https://access.redhat.com/security/cve/cve-2023-5764 (Red Hat bug 2247629; entry on cve.org)

[berndfinger]

According to GHSA-7j69-qfc3-2fq9, the versions of ansible-core in which CVE 2023-5764 is fixed are:

• 2.16.1
• 2.15.8
• 2.14.12.
  With these versions of ansible-core, the roles will fail in assertion tasks which need (but do not have) the fix for issue collection: Ensure compatibility with Ansible 2.16.1 #556.

For roles not running in assert mode, at least the following tasks are affected (grep -rn "that:" | awk '$1!~/assert-/&&/{{/{print}' - This command however will not catch multiline that: statements):

• sap_general_preconfigure: "Ensure that the length of the hostname is not longer than 'sap_general_preconfigure_max_hostname_length'"
• sap_hana_preconfigure: Ensure that the system is running a RHEL release which is supported for SAP HANA
• sap_hana_install: SAP HANA Checks - In case there is a group 'sapsys', assert that its group ID is identical to 'sap_hana_install_groupid'
• sap_hana_install: SAP HANA Add Hosts - Assert that the additional hosts are not shown in hdblcm --list_systems

[berndfinger]

According to GHSA-7j69-qfc3-2fq9, the versions of ansible-core in which CVE 2023-5764 is fixed are:

• 2.16.1
• 2.15.8
• 2.14.12.

With these versions of ansible-core, the roles will fail in assertion tasks which need (but do not have) the fix for issue collection: Ensure compatibility with Ansible 2.16.1 #556.

For roles not running in assert mode, at least the following tasks are affected (grep -rn "that:" | awk '$1!~/assert-/&&/{{/{print}' - This command however will not catch multiline that: statements):

• sap_general_preconfigure: "Ensure that the length of the hostname is not longer than 'sap_general_preconfigure_max_hostname_length'"
• sap_hana_preconfigure: Ensure that the system is running a RHEL release which is supported for SAP HANA
• sap_hana_install: SAP HANA Checks - In case there is a group 'sapsys', assert that its group ID is identical to 'sap_hana_install_groupid'
• sap_hana_install: SAP HANA Add Hosts - Assert that the additional hosts are not shown in hdblcm --list_systems

I have put the fix for these 4 items in berndfinger@3eef78a .

[audiolomb]

Thank you!!! 🥇

Merry Christmas!

[berndfinger]

Related PR for role sap_hypervisor_node_preconfigure: #586

[berndfinger]

Looks like we have finished our work on this issue.