various roles: Fix issue sap-linuxlab#556 for non-assert runs #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the roles compatible with the following versions of `ansible-core`: - 2.16.1 - 2.15.8 - 2.14.12 when running in normal (=non-assert) mode. The preconfigure roles also support an extended check mode, called assert mode, in which the roles do not change anything but verify if all settings are correct. This commit will not cover the assert mode. So several tasks of the preconfigure roles in assert mode will fail. By using the `_assert_ignore_errors` role parameters in assert mode, the roles will not fail but the affected tasks will not be executed so those settings will not be validated. Relates to issues sap-linuxlab#555 and sap-linuxlab#556. Signed-off-by: Bernd Finger <[email protected]>
berndfinger
requested review from
sean-freeman,
rhmk,
rainerleber and
ja9fuchs
berndfinger
merged commit addfda4
into
sap-linuxlab:hotfix-cve-2023-5764
1 check passed
berndfinger
deleted the
issue556-fixes-for-default-mode-into-main-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the roles compatible with the following versions of
ansible-core:The preconfigure roles also support an extended check mode, called assert mode, in which the roles do not change anything but verify if all settings are correct. This commit will not cover the assert mode. So several tasks of the preconfigure roles in assert mode will fail. By using the
_assert_ignore_errorsrole parameters in assert mode, the roles will not fail but the affected tasks will not be executed so those settings will not be validated.Relates to issues #555 and #556.