Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate returnStatusOnly and enable debugging #1356

Closed
allanbowe opened this issue Jul 18, 2023 · 1 comment · Fixed by #1361
Closed

deprecate returnStatusOnly and enable debugging #1356

allanbowe opened this issue Jul 18, 2023 · 1 comment · Fixed by #1361
Assignees
@YuryShkoda
Labels
released

Comments

@allanbowe
Copy link
Member

Currently the returnStatusOnly flag enables a 0,1,2 CLI response depending on the job success, warning, error status.

In fact, this should be the default behaviour and a flag is not required. It should be replaced with a console log (this flag is deprecated).

We can replace it with a debug flag. The aim of this is to show additional console logs, including ALL the requests to Viya (request URL & body, response headers & body).

This will significantly help in debugging, and producing test cases for future error scenarios.
@YuryShkoda YuryShkoda self-assigned this Jul 18, 2023
This was referenced Jul 27, 2023
Merged
Merged
@sasjsbot
Copy link

sasjsbot commented Aug 3, 2023

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuryShkoda YuryShkoda

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(verbose): added verbose mode and deprecated --returnStatusOnly sasjs/cli
3 participants
@allanbowe @YuryShkoda @sasjsbot