Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Dart 1 #353

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Drop support for Dart 1 #353

merged 4 commits into from
Jun 15, 2018

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 14, 2018

Now that we can depend on Dart 2 via Homebrew, we have nothing left
tying us to Dart 1.

jmesserly
jmesserly approved these changes Jun 14, 2018
View reviewed changes
Copy link

@jmesserly jmesserly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is ready for review yet, but it LGTM so far :)

nex3 added 4 commits June 14, 2018 16:13
@nex3
Stop testing against Dart's stable channel
847b639 
Once Dart 2 stable is released, we'll resume testing against stable
releases.
@nex3
Remove the workaround for dart-lang/sdk#30098
6ad67a6 
This un-reverts pull request #320 from sass/remove-path-workaround,
which was reverted by commit 0fb5d25.
@nex3
Use of() constructors instead of from()
7a2d724
@nex3
Stop using Delegating*.typed()
a31a147
@nex3 nex3 merged commit c2c77a5 into master Jun 15, 2018
@nex3 nex3 deleted the dart-2 branch June 15, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmesserly jmesserly jmesserly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @jmesserly