Hotfix master - Fix trailing-semicolon issue with nested properties #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .qux { | ||
| content: 'waldo' | ||
| } | ||
| } | ||
|
|
||
| .foo { | ||
| font: { |
There was a problem hiding this comment.
Can we add some test cases where it should fail here just to make sure?
|
Yeah good shout. |
|
also try this against it .test {
text: {
line: {
through: {
color: red;
}
}
orientation: landscape;
}
} |
|
Will do. I think it still needs some work. I'm having a issue. |
|
Ok added more test cases and also added tests to test for non-default options (include: false) |
|
Update me and we're good to go |
DanPurdy
added a commit
that referenced
this pull request
Oct 28, 2015
Hotfix master - Fix trailing-semicolon issue with nested properties
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
…esting Hotfix master - Fix trailing-semicolon issue with nested properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the trailing-semicolon false positive highlighted in #352
DCO 1.1 Signed-off-by: Ben Griffith [email protected]