-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix master - Fix trailing-semicolon issue with nested properties #359
Merged
DanPurdy
merged 6 commits into
sasstools:master
from
bgriffith:hotfix/fix-property-nesting
Oct 28, 2015
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c096e24
:bug: Fix trailing-semicolon issue with nested properties
bgriffith 9baf229
Replace type checking with .is
bgriffith 18c5083
Fix issue with no-trailing-semicolon and nested selectors
bgriffith 2cbe196
:white_check_mark: Add further test cases and include:false tests
bgriffith 3324395
Merge branch 'master' into hotfix/fix-property-nesting
bgriffith bb223f8
Merge branch 'master' into hotfix/fix-property-nesting
bgriffith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,40 @@ | ||
.foo { | ||
content: 'bar'; | ||
content: 'bar' | ||
} | ||
|
||
.bar { | ||
content: 'qux'; | ||
content: 'baz', 'fail' | ||
padding: 0 | ||
|
||
.qux { | ||
content: 'waldo' | ||
} | ||
} | ||
|
||
.qux { | ||
font: { | ||
family: 'Arial'; | ||
weight: bold; | ||
size: 2rem; | ||
} | ||
} | ||
|
||
.baz { | ||
font: { | ||
family: 'Arial'; | ||
weight: bold; | ||
size: 2rem | ||
} | ||
} | ||
|
||
.norf { | ||
border: { | ||
top: { | ||
color: red; | ||
|
||
left: { | ||
radius: 5px | ||
} | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some test cases where it should fail here just to make sure?