Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct types of CLI parameters #97

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

martinfrancois
Copy link
Contributor

@martinfrancois martinfrancois commented Oct 14, 2020

Types were taken from: https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy+Command-Line+Quick+Reference+Guide

By the way @christian-bromann, I found a mistake in the documentation linked above, it mentions --readyfile but I think it should be: --readyfile <filename>, can you please have that one corrected? Since it's a Confluence page I cannot edit it myself unfortunately :-)

And can you please tag this PR with hacktoberfest-accepted and potentially add the hacktoberfest topic to this repository? Thanks!

@martinfrancois
Copy link
Contributor Author

Any idea why the build fails on Node 8? It looks to be unrelated to my change, but it passes on master... Maybe we need to re-run the build?

@christian-bromann
Copy link
Contributor

Any idea why the build fails on Node 8?

nope, retrying

@martinfrancois
Copy link
Contributor Author

@christian-bromann did you retry? I can't see it in the builds for some reason... Maybe it would also be good to retry master (as long as that doesn't trigger any deployments or anything) to compare

@christian-bromann
Copy link
Contributor

It seems that one of our dev dependencies doesn't support Node 10 anymore.

@martinfrancois martinfrancois mentioned this pull request Oct 14, 2020
@martinfrancois
Copy link
Contributor Author

@christian-bromann I think you meant Node 8, right? I fixed it now here: #98

As soon as that one is merged, I'll rebase this one.

@martinfrancois
Copy link
Contributor Author

@christian-bromann just rebased it and the build now passes!

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job!

@christian-bromann christian-bromann added the Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest label Oct 15, 2020
@christian-bromann christian-bromann merged commit cb6abd3 into saucelabs:master Oct 15, 2020
@martinfrancois
Copy link
Contributor Author

Thanks a lot!

@martinfrancois martinfrancois deleted the patch-1 branch October 15, 2020 11:44
@martinfrancois
Copy link
Contributor Author

@christian-bromann will a release on this one follow soon? Then we could already include it in @wdio/sauce-service as well!

@christian-bromann
Copy link
Contributor

@martinfrancois just released as v4.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants