-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct types of CLI parameters #97
Conversation
Any idea why the build fails on Node 8? It looks to be unrelated to my change, but it passes on master... Maybe we need to re-run the build? |
nope, retrying |
@christian-bromann did you retry? I can't see it in the builds for some reason... Maybe it would also be good to retry master (as long as that doesn't trigger any deployments or anything) to compare |
It seems that one of our dev dependencies doesn't support Node 10 anymore. |
@christian-bromann I think you meant Node 8, right? I fixed it now here: #98 As soon as that one is merged, I'll rebase this one. |
3af4ac2
to
fd65350
Compare
@christian-bromann just rebased it and the build now passes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great job!
Thanks a lot! |
@christian-bromann will a release on this one follow soon? Then we could already include it in |
@martinfrancois just released as v4.5.1 |
Types were taken from: https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy+Command-Line+Quick+Reference+Guide
By the way @christian-bromann, I found a mistake in the documentation linked above, it mentions
--readyfile
but I think it should be:--readyfile <filename>
, can you please have that one corrected? Since it's a Confluence page I cannot edit it myself unfortunately :-)And can you please tag this PR with
hacktoberfest-accepted
and potentially add thehacktoberfest
topic to this repository? Thanks!