Fix Node 8 Build #98
Merged
Fix Node 8 Build #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All versions higher than 2.0.5 are NOT compatible with Node 8 and result in the build failing. Signed-off-by: martinfrancois <[email protected]>
Versions not supported by Node 8: - Jest from >=26.0.0 - Prettier from >2.0.5 - Eslint from >=7.0.0 Signed-off-by: martinfrancois <[email protected]>
This is recommended by npm, when running `npm install`: ``` npm notice created a lockfile as package-lock.json. You should commit this file. ``` This enables running `npm ci` on CI to consistently use the same dependency versions as of the state of `package-lock.json`. This makes builds more reproducible, since they cannot break due to updated dependencies, which introduce breaking changes in minor or patch version upgrades. Signed-off-by: martinfrancois <[email protected]>
christian-bromann
approved these changes
Oct 15, 2020
|
@christian-bromann Thanks for merging! Could you please add a label for |
christian-bromann
added
the
Hacktoberfest
|
@martinfrancois is it needed given that the repo already has a hacktoberfest topic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #97
I tried running the build on master in my fork and noticed that it was failing too.
After trying out different versions for different dependencies I found that the culprit was the
prettierdependency, which causes themasterto fail since the version is specified as^2.0.5, which means it will use any2.x.xversion which is>=2.0.5. Specifically, every version>2.0.5, so for instance2.1.0causes the build to fail.To fix the issue, I set the version of
prettierto2.0.5, since this is the last version which works with Node 8.I also updated all of the dependencies to their latest versions which still work with Node 8.
In particular, the following dependencies and versions are NOT working with Node 8:
To prevent an issue like in #97 from happening again in the future, I commited the
package-lock.jsonfile, as is recommended by npm, shown in a message on every run:By doing so, Travis CI will use
npm ciinstead ofnpm install, which will read the dependency information from there, which is reproducible (in contrast topackage.json, which has version ranges defined) since it exactly defines which version of which dependency and sub-dependency is used.This means, as long as the
package-lock.jsonfile is not changed, someone making a PR in any amount of months where a dependency introduces a breaking change in a minor / patch version accidentally, it will not cause the build to fail, as long aspackage-lock.jsonis not changed.