Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for cookies when using custom headers #771

Merged
merged 2 commits into from
Oct 13, 2016

Conversation

nielsbuus
Copy link
Contributor

This commit configures cookies AFTER configuring headers. This is necessary because the header configuration method resets existing headers, including cookies.

nielsbuus and others added 2 commits July 1, 2016 17:20
This commit configures cookies AFTER configuring headers. This is necessary because the header configuration method resets existing headers, including cookies.
@kronn
Copy link

kronn commented Aug 31, 2016

How can me move this one forward? The broken build seems to be unrelated to the change. I would very much like to switch from the PRs fork to an official gem version with that change.

@tjarratt tjarratt merged commit b72ab39 into savonrb:master Oct 13, 2016
@tjarratt
Copy link
Contributor

@nielsbuus I appreciate the contributions and all but ... did you really mean to include the changes to README.md along with the code change?

@nielsbuus
Copy link
Contributor Author

@tjarratt No, I didn't. If you look at the history, there are two weeks between the commits. The first commit is the fix and the second commit was added to the repository when I grew tired of waiting and had to document the motivation for the fork.

Since the pull request merges our master into savonrb master, the update to our master inadvertently became part of this open pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants