Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for cookies when using custom headers #771

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Restore support for cookies when using custom headers #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d0831
Restore support for cookies when using custom headers
nielsbuus Jul 1, 2016
78dd78b
Update README.md
Jul 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# NOTICE: This is a fork of savonrb/savon

It's forked because savonrb has a bug when headers and sessions are combined, and even though we have opened a pull request for a fix on the official repo, it seems that:

![Nobody cares](https://cdn.meme.am/instances/500x/22118345.jpg)

Because of that, we are using this fork. Hopefully not for long, as the savon/rconomic duo should be retired from our systems in favor of using E-conomic's shiny new JSON/REST API.

---

# Savon

Heavy metal SOAP client
Expand Down
2 changes: 1 addition & 1 deletion lib/savon/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ class SOAPRequest < HTTPRequest

def build(options = {})
configure_proxy
configure_cookies options[:cookies]
configure_timeouts
configure_headers options[:soap_action], options[:headers]
configure_cookies options[:cookies]
configure_ssl
configure_auth
configure_redirect_handling
Expand Down