Fix building for test #799
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2017 16:36
|
Hello? |
|
@tjarratt are you a maintainer? |
|
@rubiii @timabdulla @tjarratt are you already not interested in savon product? |
|
Hi - thanks for the PR! I checked out master just now, and successfully built puma + ran tests fine. I prefer to not be locked to a beta version of puma, but I think puma 3.x drops support for ruby 2.0 though, I will revisit this when I have more clarity on the state of ruby 2.0 support in savon. |
|
@syguer thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 😄
I found some problems for testing.
bundle installand looks it is caused by using too old versionuninitialized constant Rack::Authhas raised because spec file requires only 'rake/builder'I fixed these 👍