Fix a problem when http.body is empty #800

syguer · 2017-03-13T08:58:57Z

When http.body is empty, SOAPFault#to_s raises error because SOAPFault#to_hash called by SOAPFault#to_s returns nil.

I think #to_hash should returns Hash rather than nil 🤔

When http.body is empty, #to_s raises error. Because #to_hash called by #to_s returns nil

syguer · 2017-03-13T09:01:14Z

spec will be all green after #799 is merged

syguer · 2017-03-13T09:09:48Z

Should I bump up version?

pcai · 2017-07-29T02:26:47Z

Thanks for the fix!

Izumiya Keisuke added 2 commits March 13, 2017 17:25

Fix a problem when http.body is empty

0cf931a

When http.body is empty, #to_s raises error. Because #to_hash called by #to_s returns nil

Update CHANGELOG.md

ed852b8

pcai merged commit cd7efa1 into savonrb:master Jul 29, 2017

Provide feedback