-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types #411
Closed
Closed
Fix types #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update algob-test * add test
* add jobs * add docs Co-authored-by: Amit Yadav <[email protected]>
* check with node * add deploy commands Co-authored-by: Ratik Jindal <[email protected]>
* add algob-web * add errors * update runtime package * add web mode class * remove types-input * update algob package * rename web, change import to scope * update algob * update change log Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Ratik Jindal <[email protected]>
* update & add new contract and script * update comment scripts * add cease.js * add set-permission-appid.js * add happy tests * add failing tests * update readme * update changelog * Apply suggestions from code review Co-authored-by: Amit Yadav <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
* fix opt-in and add test
* add update test * update Co-authored-by: Ratik Jindal <[email protected]>
* update algob init * update project-creation.ts * update sample project composition * update readme and changelog Co-authored-by: Amit Yadav <[email protected]>
* add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
Proposed Changes
User is not able to reassign
fromAccount
because it doesn't exist in bothSignWithSk
andSignWithLsig
.Tried using: convert type to interface but this doen't work and it also breaks different address and different signing feature