-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARSN-392 Put metadata to a standalone null master breaks CloudServer CRUD #2215
Conversation
This logic is used by CRR replication feature to BackbeatClient.putMetadata on top of a null version
Hello nicolas2bert,My role is to assist you with the merge of this Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few suggestions to improve the moved code
- Add the nullVersionId field into the master update. The nullVersionId is needed for listing, retrieving, and deleting null version. - Manage scenarios in which a version is marked with the isNull attribute set to true, but without a version ID. It happens after BackbeatClient.putMetadata() is applied to a standalone null master.
527ebe7
to
46258bc
Compare
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/7.70/bugfix/ARSN-392/null origin/development/7.70
$ git merge origin/bugfix/ARSN-392/null
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/ARSN-392/null The following options are set: create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
@bert-e approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-392. Goodbye nicolas2bert. |
Functionally tested here: scality/cloudserver#5531
Notes:
NOTE1: This change is only impacting the "file" metadata backend logic. Similar fixes will be implemented in scality/Metadata using
Arsenal.updateOrAppendNullVersionId()
method.NOTE2: null version key is handled very differently from development/7.10 to development/7.70 where:
This change won't be forward-ported to development/7.70. We will create a different PR: ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216 targeting development/7.70.
Description:
cbe6a5e: File backend should be "mocking" the V0 metadata backend. To fix it, we imported the V0 processVersionSpecificPut from scality/Metadata.
46258bc:
Add the
nullVersionId
field into the master update. ThenullVersionId
is needed for listing, retrieving, and deleting null versions.Manage scenarios in which a version is marked with the
isNull
attribute set totrue
, but without aversion ID
.It happens after
BackbeatClient.putMetadata()
is applied to a standalone null master.