ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216

nicolas2bert · 2024-02-12T16:29:14Z

NOTE: This change is only impacting the "file" metadata backend logic. Similar fixes will be implemented in scality/Metadata using Arsenal.updateOrAppendNullVersionId() method.

Description:

1653fd2: "File" metadata backend should be "mocking" the V0 scality/Metadata backend. To fix it, we imported the V0 processVersionSpecificPut from scality/Metadata.

58d0622:

For "null key" backward compatibility (if isNull is undefined), add the nullVersionId field to the master update. The nullVersionId is needed for listing, retrieving, and deleting null versions. 
For the new null key implementation (if isNull is defined): add the isNull2 field and set it to true to specify that the new version is null AND has been put with a Cloudserver handling null keys (i.e., supporting S3C-7352). 
Manage scenarios in which a version is marked with the isNull attribute set to true, but without a version ID. This happens after BackbeatClient.putMetadata() is applied to a standalone null master.

bert-e · 2024-02-12T16:29:17Z

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2024-02-12T16:29:22Z

Incorrect fix version

The Fix Version/s in issue ARSN-392 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.70.24
8.1.123

Please check the Fix Version/s of ARSN-392, or the target
branch of this pull request.

nicolas2bert · 2024-02-12T16:34:06Z

lib/versioning/Version.ts

+     * _jsonAppend('{"existingKey":"existingValue"}', 'newKey', 'newValue');
+     * // returns '{"existingKey":"existingValue","newKey":"newValue"}'
+     */
+    static _jsonAppend(stringifiedObject: string, key: string, value: string): string {


If you have already reviewed #2215, there's no need to do so again as it is a duplicate.

nicolas2bert · 2024-02-12T16:34:18Z

lib/versioning/Version.ts

+    * @param {string} nullVersionId - The new value for the `nullVersionId` property to be updated or appended.
+    * @returns {string} The updated JSON-formatted string with the new `nullVersionId` value.
+    */
+    static updateOrAppendNullVersionId(value: string, nullVersionId: string): string {


If you have already reviewed #2215, there's no need to do so again as it is a duplicate.

nicolas2bert · 2024-02-12T16:34:26Z

tests/unit/versioning/Version.spec.js

@@ -0,0 +1,55 @@
+const { Version } = require('../../../lib/versioning/Version');
+
+describe('Version', () => {


If you have already reviewed #2215, there's no need to do so again as it is a duplicate.

lib/versioning/VersioningRequestProcessor.ts

bert-e · 2024-02-13T15:37:27Z

Incorrect fix version

The Fix Version/s in issue ARSN-392 contains:

7.10.58
7.70.24
8.1.123

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.70.24
8.1.123

Please check the Fix Version/s of ARSN-392, or the target
branch of this pull request.

jonathan-gramain

LGTM (thanks for updating this version-specific PUT function by the way, it was not obvious at all!)

lib/versioning/Version.ts

lib/versioning/VersioningRequestProcessor.ts

bert-e · 2024-02-19T11:08:50Z

Incorrect fix version

The Fix Version/s in issue ARSN-392 contains:

7.10.59
7.70.26
8.1.124

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.70.26
8.1.124

Please check the Fix Version/s of ARSN-392, or the target
branch of this pull request.

This logic is used by CRR replication feature to BackbeatClient.putMetadata on top of a null version

- For backward compatibility (if isNull is undefined), add the nullVersionId field to the master update. The nullVersionId is needed for listing, retrieving, and deleting null versions.  - For the new null key implementation (if isNull is defined): add the isNull2 field and set it to true to specify that the new version is null AND has been put with a Cloudserver handling null keys (i.e., supporting S3C-7352).  - Manage scenarios in which a version is marked with the isNull attribute set to true, but without a version ID. This happens after BackbeatClient.putMetadata() is applied to a standalone null master.

nicolas2bert · 2024-02-20T14:21:48Z

ping

bert-e · 2024-02-20T14:21:58Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

nicolas2bert · 2024-02-20T14:22:08Z

/create_integration_branches

bert-e · 2024-02-20T14:22:18Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/ARSN-392/null7.70 into
development/7.70
w/8.1/bugfix/ARSN-392/null7.70 will be merged into development/8.1

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2024-02-20T14:22:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

nicolas2bert · 2024-02-21T08:39:47Z

@bert-e approve

bert-e · 2024-02-21T08:40:02Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/7.70
✔️ development/8.1

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2024-02-21T08:40:13Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.70
✔️ development/8.1

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4

Please check the status of the associated issue ARSN-392.

Goodbye nicolas2bert.

nicolas2bert mentioned this pull request Feb 12, 2024

ARSN-392 Put metadata to a standalone null master breaks CloudServer CRUD #2215

Merged

nicolas2bert commented Feb 12, 2024

View reviewed changes

nicolas2bert commented Feb 13, 2024

View reviewed changes

lib/versioning/VersioningRequestProcessor.ts Show resolved Hide resolved

nicolas2bert force-pushed the bugfix/ARSN-392/null7.70 branch from 5178536 to dc22643 Compare February 14, 2024 14:02

nicolas2bert mentioned this pull request Feb 14, 2024

CLDSRV-501 [7.70] PutMetadata should write metadata on top of a null version scality/cloudserver#5532

Closed

jonathan-gramain approved these changes Feb 15, 2024

View reviewed changes

nicolas2bert force-pushed the bugfix/ARSN-392/null7.70 branch from dc22643 to 58d0622 Compare February 19, 2024 11:08

nicolas2bert added 2 commits February 20, 2024 15:18

ARSN-392 Import the V0 processVersionSpecificPut from Metadata

40e271f

This logic is used by CRR replication feature to BackbeatClient.putMetadata on top of a null version

nicolas2bert force-pushed the bugfix/ARSN-392/null7.70 branch from 58d0622 to 6820444 Compare February 20, 2024 14:20

BourgoisMickael approved these changes Feb 20, 2024

View reviewed changes

bert-e merged commit 6820444 into development/7.70 Feb 21, 2024
7 checks passed

bert-e deleted the bugfix/ARSN-392/null7.70 branch February 21, 2024 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216

ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216

nicolas2bert commented Feb 12, 2024 •

edited

Loading

bert-e commented Feb 12, 2024

bert-e commented Feb 12, 2024

nicolas2bert Feb 12, 2024

nicolas2bert Feb 12, 2024

nicolas2bert Feb 12, 2024

bert-e commented Feb 13, 2024

jonathan-gramain left a comment

bert-e commented Feb 19, 2024

nicolas2bert commented Feb 20, 2024

bert-e commented Feb 20, 2024

nicolas2bert commented Feb 20, 2024

bert-e commented Feb 20, 2024

bert-e commented Feb 20, 2024

nicolas2bert commented Feb 21, 2024

bert-e commented Feb 21, 2024

bert-e commented Feb 21, 2024

		@@ -0,0 +1,55 @@
		const { Version } = require('../../../lib/versioning/Version');

		describe('Version', () => {

ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216

ARSN-392 [7.70] Put metadata to a standalone null master breaks CloudServer CRUD #2216

Conversation

nicolas2bert commented Feb 12, 2024 • edited Loading

bert-e commented Feb 12, 2024

Hello nicolas2bert,

bert-e commented Feb 12, 2024

Incorrect fix version

nicolas2bert Feb 12, 2024

Choose a reason for hiding this comment

nicolas2bert Feb 12, 2024

Choose a reason for hiding this comment

nicolas2bert Feb 12, 2024

Choose a reason for hiding this comment

bert-e commented Feb 13, 2024

Incorrect fix version

jonathan-gramain left a comment

Choose a reason for hiding this comment

bert-e commented Feb 19, 2024

Incorrect fix version

nicolas2bert commented Feb 20, 2024

bert-e commented Feb 20, 2024

Request integration branches

nicolas2bert commented Feb 20, 2024

bert-e commented Feb 20, 2024

Integration data created

bert-e commented Feb 20, 2024

Waiting for approval

nicolas2bert commented Feb 21, 2024

bert-e commented Feb 21, 2024

In the queue

bert-e commented Feb 21, 2024

nicolas2bert commented Feb 12, 2024 •

edited

Loading