Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Bring back the water ripples background animation #285

Closed
loveu5522 opened this issue Mar 25, 2024 · 4 comments · Fixed by #378
Closed

[Enhancement] Bring back the water ripples background animation #285

loveu5522 opened this issue Mar 25, 2024 · 4 comments · Fixed by #378
Labels
enhancement New feature or request UI/UX

Comments

@loveu5522
Copy link

snapdrop of Water ripples are moveable
@loveu5522 loveu5522 added the bug Something isn't working label Mar 25, 2024
@schlagmichdoch
Copy link
Owner

I have responded to this question before:

The background animation is abolished purposely. Firstly, the behavior is inconsistent as implemented into Snapdrop, as it does not start again when all peers have left. This was fixed in the beginning of PairDrop. But secondly, this animation (and all versions with a smarter logic I tried) are a heavy strain on CPU and/or GPU. See #75 and b42c8a0
In the end I decided to remove the background animation in favor of speed and efficiency. I also prefer the calmness of the GUI when the PWA is running all the time.

If you really miss this, please create a new separate issue for it. If enough users really do like the animation I will try to come up with a way without it straining the CPU/GPU (probably removing transparency changes would help).

Originally posted by @schlagmichdoch in #210 (comment)

Although this is more or less a duplicate I'll leave this to be decided. If enough people prefer some background animation I'll maybe try to come up with a way.

@schlagmichdoch schlagmichdoch added enhancement New feature or request UI/UX and removed bug Something isn't working labels May 16, 2024
@schlagmichdoch schlagmichdoch changed the title [Bug] The water ripples on the interface do not move [Enhancement] Bring back the water ripples background animation May 16, 2024
@Mitia99
Copy link

Mitia99 commented Aug 20, 2024

+1 for the water ripples animation if it doesn't affect performance.

The current Pairdrop static UI gives a feeling of an app freeze if you compare it with Snapdrop.

This was referenced Feb 12, 2025
Closed
Closed
Merged
schlagmichdoch added a commit that referenced this issue Feb 17, 2025
@schlagmichdoch
Increase version to v1.11.0
b3c61f4 
## Enhancements
- Make PWA standalone (#264)
- Bring back background animation after performance optimization (#285)
- Add support for Safari 11-15 (#358)
- Update Twitter icon and URL to (X) (Thanks @realchrislovett)
- Update node dependencies

## Fixes
- Fix pasting of files on background to invoke share-mode and make it available on Firefox (#370)
- Fix padding issue on EditPairedDevicesDialog and Base64Dialog
- Fix hydration of URLs into links in received messages that have exclamation marks in path

## Languages
- Translations updates from Hosted Weblate (Basque, Norwegian Bokmål)
@Mitia99
Copy link

Mitia99 commented Feb 25, 2025

@schlagmichdoch The animation stops when there is paired device. Thanks for investigating

@schlagmichdoch
Copy link
Owner

@Mitia99 That's by design since the Snapdrop days. What's fixed is that the animation restarts as soon as all peers have left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request UI/UX
Projects
None yet
Milestone
No milestone
3 participants
@loveu5522 @schlagmichdoch @Mitia99