-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Pasting of images does not work (on mobile) #370
Comments
@blamedrop Would be great if you could add some more info:
|
Hi! Sorry for the late reply. The issue is that basically nothing happens when I do On Yesterday, I did test it and I got same 'nothing happens' behavior on various OS/browsers:
I see you've pushed a fix but I guess it isn't live yet? Ping me when it's up and I'll test it. |
On PairDrop you have a share-mode when you paste elements (either text or files/images). When you drag and drop elements on the background (or when no peers are connected) the share-mode is initiated as well.
It was implemented in such a way, that pasting a file when only one peer was connected would sent the file to that peer directly. Everything else did not work and there was only documentation in the code ;-) The fixes are on master but are not bundled into a new version yet and therefor are not live on pairdrop.net. |
Oh, I see! Indeed, Had no idea that there was this mode and that pasting on the main screen would do anything! I guess you could update the But still - on mobile phone, I don't think I can paste it anyhow, other that in the text box where it still does not work. I guess handling pasting images in the text area could solve both of these issues? Not gonna lie, SnapDrop's handling of it in the text box after selecting peer was somewhat intuitive, despite that this whole webapp kinda follows Apple's how-the-fuck-I'm-supposed-to-figure-out-that-there-was-this-feature-hidden style of UIs ;) |
Great! Thanks for testing!
FYI: That mode is also used if you install PairDrop as PWA on Android and share files directly from the Android share menu or when using the iOS shortcut to do the same on iOS devices. We will need to think about how to improve the information architecture though. Anything that is hidden like on the About page will probably never be read so it must be on the main page. Not sure how to keep everything tidy though.
This was not how it was implemented though and worked simply by accident. It just did not check if the message dialog was open and handled it as if something was pasted in the background. When only one peer was connected the file was sent. When more peers were connected nothing happened at all.
If users think they have text in their clipboard that would simply be inserted in the text field but instead a file in their clipboard gets sent directly is somewhat unexpected, don't you think? I would rather have a consistent way of doing this by using the share-mode which is especially useful to share the same file(s)/text/link to multiple users. I have also thought about adding a possibility to select files in the UI first and select the receiver(s) via the share-mode after. |
I just recognized that on mobile it works by pasting files in the display name text field ;-) |
## Enhancements - Make PWA standalone (#264) - Bring back background animation after performance optimization (#285) - Add support for Safari 11-15 (#358) - Update Twitter icon and URL to (X) (Thanks @realchrislovett) - Update node dependencies ## Fixes - Fix pasting of files on background to invoke share-mode and make it available on Firefox (#370) - Fix padding issue on EditPairedDevicesDialog and Base64Dialog - Fix hydration of URLs into links in received messages that have exclamation marks in path ## Languages - Translations updates from Hosted Weblate (Basque, Norwegian Bokmål)
Originally posted by @blamedrop in #651
The text was updated successfully, but these errors were encountered: