Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search then paginate does not work #357

Closed
1 task
jillpe opened this issue Jun 22, 2023 · 4 comments
Closed
1 task

Search then paginate does not work #357

jillpe opened this issue Jun 22, 2023 · 4 comments
Assignees
@laritakr
Labels
bug something isn't working

Comments

@jillpe
Copy link

jillpe commented Jun 22, 2023 •
edited by laritakr
Loading

Summary

When you search in the catalog, then try to paginate, it errors out. This seems to happen only after you search for something. If you do an empty search the pagination is fine.

example
Screen.Recording.2023-06-22.at.10.42.06.AM.mov

Accepted Criteria

  • Pagination does not error out upon a search in the catalog

Testing Instructions

Recreate the search for FLOOR in ADL staging, and paginate to page two. Verify that pagination resolves correctly.
@jillpe jillpe added the bug something isn't working label Jun 22, 2023
@ShanaLMoore ShanaLMoore self-assigned this Jun 26, 2023
@ShanaLMoore
Copy link

ShanaLMoore commented Jun 26, 2023 •
edited
Loading

This is a weird one.

This only seems to be happening on staging, and with the specific word "floor". I randomly searched for other words like 'index' and 'cat' and am able to paginate just fine. No errors are being reported to sentry.

Screen Recording 2023-06-26 at 03 29 42 PM

Searching for the word floor in prod is fine. So far I haven't been able to reproduce this locally.

@ShanaLMoore ShanaLMoore assigned laritakr and unassigned ShanaLMoore Jun 27, 2023
@laritakr
Copy link
Contributor

laritakr commented Jun 28, 2023 •
edited
Loading

Sentry error: https://scientist-inc.sentry.io/issues/4278561363/events/30c0aee28b9547f9bc7dc97692617a0e/

The problem is apparently due to a work with 5 snippets attempting to render on the catalog page (it was on page 2, so that's why pagination triggered the issue). However, there seems to be more to it than just this, because so far I have been unable to duplicate the problem locally.

There were two works on staging that had this problem. IDs are c11b7e48-cf2a-4254-ac4e-3a2f4e895646 and 2d29f952-d0d5-4781-8680-f5607e61f685, both GenericWork objects.

The file that caused the error is this one:
iiif-print-test.pdf

@jillpe jillpe mentioned this issue Jun 29, 2023
Closed
3 tasks
@laritakr laritakr mentioned this issue Jun 29, 2023
Merged
laritakr referenced this issue in notch8/iiif_print Jun 29, 2023
Move helper for snippets method
e770b6f 
Ref: https://github.com/scientist-softserv/adventist-dl/issues/469
Method `render_ocr_snippets` was causing AbstractController::DoubleRenderError
() during random situations, due to including the IiifPrintHelper in
ApplicationController.

This pull request moves it into a helper module which is injected by the
install generator, which matches how it was done in LV & NNP. See
https://github.com/scientist-softserv/louisville-hyku/blob/b672d2a3213aaee84c082eb8083d8ad70733036b/app/helpers/newspaper_works_helper.rb#L3
@laritakr laritakr mentioned this issue Jun 29, 2023
Merged
laritakr referenced this issue in notch8/adventist-dl Jun 29, 2023
Move render_ocr_snippets method
9074800 
Ref #469 & notch8/iiif_print#254

Update IiifPrint to use a branch that:
- does not include derivative rodeo, which broke PDF splitting
- moves render_ocr_snippets method to an appropriate helpers

Remove definition from application controller.
Add iiif_print_helper to pull in behavior.
@laritakr laritakr mentioned this issue Jun 29, 2023
Merged
laritakr referenced this issue in notch8/iiif_print Jun 29, 2023
🐛 Move helper for snippets method
7ce73b4 
Ref: https://github.com/scientist-softserv/adventist-dl/issues/469
Method `render_ocr_snippets` was causing AbstractController::DoubleRenderError
() during random situations, due to including the IiifPrintHelper in
ApplicationController.

This pull request moves it into a helper module which is injected by the
install generator, which matches how it was done in LV & NNP. See
https://github.com/scientist-softserv/louisville-hyku/blob/b672d2a3213aaee84c082eb8083d8ad70733036b/app/helpers/newspaper_works_helper.rb#L3
@ShanaLMoore ShanaLMoore mentioned this issue Jun 30, 2023
Merged
laritakr referenced this issue in notch8/adventist-dl Jun 30, 2023
🐛 Move render_ocr_snippets method
dc26ae1 
Ref #469 & notch8/iiif_print#254

* Update IiifPrint to use a branch that:
  - does not include derivative rodeo, which broke PDF splitting
  - moves render_ocr_snippets method to an appropriate helpers

* Remove render_ocr_snippets definition from application controller.
* Add iiif_print_helper to pull in behavior.
laritakr referenced this issue in notch8/adventist-dl Jun 30, 2023
🐛 Move render_ocr_snippets method
213f2cf 
Ref #469 & notch8/iiif_print#254

* Update IiifPrint to use a branch that:
  - does not include derivative rodeo, which broke PDF splitting
  - moves render_ocr_snippets method to an appropriate helpers

* Remove render_ocr_snippets definition from application controller.
* Add iiif_print_helper to pull in behavior.
laritakr referenced this issue in notch8/adventist-dl Jun 30, 2023
🐛 Move render_ocr_snippets method
af4ec8e 
Ref #469 & notch8/iiif_print#254

* Update IiifPrint to use a branch that:
  - does not include derivative rodeo, which broke PDF splitting
  - moves render_ocr_snippets method to an appropriate helpers

* Remove render_ocr_snippets definition from application controller.
* Add iiif_print_helper to pull in behavior.
@laritakr laritakr mentioned this issue Jun 30, 2023
Merged
jeremyf referenced this issue in notch8/iiif_print Jul 5, 2023
@jeremyf
🐛 Move helper for snippets method
bdadcc0 
Ref: https://github.com/scientist-softserv/adventist-dl/issues/469
Method `render_ocr_snippets` was causing AbstractController::DoubleRenderError
() during random situations, due to including the IiifPrintHelper in
ApplicationController.

This pull request moves it into a helper module which is injected by the
install generator, which matches how it was done in LV & NNP. See
https://github.com/scientist-softserv/louisville-hyku/blob/b672d2a3213aaee84c082eb8083d8ad70733036b/app/helpers/newspaper_works_helper.rb#L3
@DiemBTran
Copy link

This passes SoftServ QA: See attached screen recording.

tested on:

Search and pagination works for term "floor"
Screen.Recording.2023-07-05.at.11.34.48.AM.mp4

@DiemBTran
Copy link

does not require client QA

@laritakr laritakr mentioned this issue Jul 5, 2023
Merged
@kirkkwang kirkkwang transferred this issue from notch8/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
bug something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShanaLMoore @laritakr @DiemBTran @jillpe