Move "No Rodeo" updates into main #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add assurance that we are getting the FileSet id and not some other work type id.
It seems `default` should be `default_coords` in this case.
Ref: https://github.com/scientist-softserv/adventist-dl/issues/469 Method `render_ocr_snippets` was causing AbstractController::DoubleRenderError () during random situations, due to including the IiifPrintHelper in ApplicationController. This pull request moves it into a helper module which is injected by the install generator, which matches how it was done in LV & NNP. See https://github.com/scientist-softserv/louisville-hyku/blob/b672d2a3213aaee84c082eb8083d8ad70733036b/app/helpers/newspaper_works_helper.rb#L3
…paginate 🐛 I469 adv search then paginate
caused pipeline to fail on command: 'bundle exec rake prepare_and_run_tests'. ref: 01ef2aa
|
handled via #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
The Derivative Rodeo work in main broke PDF splitting, so this branch contains all non-rodeo update, to keep IiifPrint functioning until the main branch is fixed. Updates here need to be merged to be included in main as well.
Notes
@jeremyf