Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pyodide (again!) #2326

Merged
merged 3 commits into from
Mar 20, 2023
Merged

docs: fix pyodide (again!) #2326

merged 3 commits into from
Mar 20, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Mar 20, 2023

This PR reworks the fix in #2318. That fix was valid, but we need to wait until we can build for pyodide 0.22.0, which is given by #2062.

I usually use the docs release to rapidly test "in-the-wild" Awkward Array. I noticed that the build is currently broken.

@agoose77 agoose77 temporarily deployed to docs-preview March 20, 2023 15:23 — with GitHub Actions Inactive
@agoose77 agoose77 changed the base branch from main to agoose77/docs-emsdk-version March 20, 2023 17:35
@agoose77 agoose77 closed this Mar 20, 2023
@agoose77 agoose77 reopened this Mar 20, 2023
@agoose77 agoose77 changed the base branch from agoose77/docs-emsdk-version to main March 20, 2023 18:04
@agoose77 agoose77 changed the title docs: fix missing Python kernel! docs: fix pyodide (again!) Mar 20, 2023
@agoose77 agoose77 marked this pull request as ready for review March 20, 2023 18:05
@agoose77 agoose77 requested a review from jpivarski March 20, 2023 18:17
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agoose77 agoose77 temporarily deployed to docs-preview March 20, 2023 18:28 — with GitHub Actions Inactive
@agoose77 agoose77 changed the title docs: fix pyodide (again!) docs: fix pyodide (again!) (#2326 Mar 20, 2023
@agoose77 agoose77 merged commit 8de9044 into main Mar 20, 2023
@agoose77 agoose77 deleted the agoose77/docs-fix-pyodide branch March 20, 2023 18:39
@agoose77 agoose77 changed the title docs: fix pyodide (again!) (#2326 docs: fix pyodide (again!) Mar 20, 2023
ianna pushed a commit that referenced this pull request Mar 21, 2023
* docs: fix missing Python kernel!

* docs: fix pyodide-build
ianna added a commit that referenced this pull request Mar 21, 2023
* feat: use cppyy for JIT

* test: convert function

* fix: cleanup

* fix: cleanup and assert check in the tests

* test: enable more tests

* fix: lower cppyy version requirement

* docs: update comments

* fix: expose array interface for CUDA (#2327)

* fix: expose array interface for CUDA

* test: cover other cases

* docs: fix pyodide (again!) (#2326

* docs: fix missing Python kernel!

* docs: fix pyodide-build

* fix: update magic function name

* fix: updated to the latest cppyy version.

* fix: pass it either by reference or by value

* fix: the minimum required cppyy version is 3.0.1

* Update src/awkward/cppyy.py

Co-authored-by: Jim Pivarski <[email protected]>

* Update src/awkward/cppyy.py

Co-authored-by: Jim Pivarski <[email protected]>

---------

Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Jim Pivarski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants