fix: expose array interface for CUDA #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianna
pushed a commit
that referenced
this pull request
Mar 21, 2023
* fix: expose array interface for CUDA * test: cover other cases
ianna
added a commit
that referenced
this pull request
Mar 21, 2023
* feat: use cppyy for JIT * test: convert function * fix: cleanup * fix: cleanup and assert check in the tests * test: enable more tests * fix: lower cppyy version requirement * docs: update comments * fix: expose array interface for CUDA (#2327) * fix: expose array interface for CUDA * test: cover other cases * docs: fix pyodide (again!) (#2326 * docs: fix missing Python kernel! * docs: fix pyodide-build * fix: update magic function name * fix: updated to the latest cppyy version. * fix: pass it either by reference or by value * fix: the minimum required cppyy version is 3.0.1 * Update src/awkward/cppyy.py Co-authored-by: Jim Pivarski <[email protected]> * Update src/awkward/cppyy.py Co-authored-by: Jim Pivarski <[email protected]> --------- Co-authored-by: Angus Hollands <[email protected]> Co-authored-by: Jim Pivarski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ak.index.Index(existing_index)doesn't work for CuPy arrays. We rely on being able to do this in our internal layout logic.I think what happens is that CuPy asks NumPy to read this array, which then fails as what's returned is not a NumPy array.
We can generalise our index to expose the various array interfaces. In the longer term, we should also expose DLPack.