Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip histosys modifier creation for single-bin regions #398

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Apr 1, 2023

There is no need to create histosys modifiers for single-bin regions, as the full effect is already absorbed into the normsys modifier created in that case.

* skip superfluous histosys modifier creation for single-bin regions

resolves #354

@alexander-held alexander-held changed the title feat: skip histosys modifier creation for single-bin channels feat: skip histosys modifier creation for single-bin regions Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (03f274f) 100.00% compared to head (dccbaa9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2065      2066    +1     
  Branches       326       327    +1     
=========================================
+ Hits          2065      2066    +1     
Impacted Files Coverage Δ
src/cabinetry/workspace.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held merged commit d761e30 into master Apr 2, 2023
@alexander-held alexander-held deleted the feat/skip-histosys-single-bin branch April 2, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip histosys modifiers for single-bin regions
1 participant