Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy code to port #48

Closed
wants to merge 48 commits into from
Closed

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Nov 2, 2022

Merge postponed.
Before merging (an updated version of) this pr, the following will be isolated in a separate pr, improved, and merged.

  • coordinate systems
  • coordinate transformations
  • io branch from @giovp

About this pr.

This pull request implements a first working version of coordinate systems, transformations, as long as all what spatialdata needs to perform basic io operatations with its elements. Spatialdata-sandbox and napari_spatialdata support this branch. They will also need to be adapted to the new improved code described in the incremental prs listed above.

giovp and others added 30 commits August 17, 2022 09:05
* add io test

* [pre-commit.ci] pre-commit autoupdate (#13)

updates:
- [github.com/asottile/yesqa: v1.3.0 → v1.4.0](asottile/yesqa@v1.3.0...v1.4.0)
- [github.com/PyCQA/flake8: 5.0.1 → 5.0.4](PyCQA/flake8@5.0.1...5.0.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@LucaMarconato LucaMarconato changed the title enough features for the first applications enough features for the first applications (wip) Nov 2, 2022
@kevinyamauchi
Copy link
Collaborator

kevinyamauchi commented Dec 13, 2022

@LucaMarconato , can this PR be closed now that #52 has landed?

@LucaMarconato
Copy link
Member Author

@kevinyamauchi unfortunately not, it has features that are not merged yet. I plan to work on this over the the christmas holidays (should be 1-2 days of work).

@LucaMarconato LucaMarconato marked this pull request as draft December 13, 2022 15:46
@kevinyamauchi
Copy link
Collaborator

No worries, @LucaMarconato ! Just checking in to see if I needed to do anything here 😛

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Jan 4, 2023

Instead of merging this branch, which is very outdated, I will pick the following and merge it in multiple prs. The rest can be discarded.

  • filter_by_coordinate_system() from _spatialdata.py
  • concatenate() from _spatialdata.py
  • generate multiscale from multiscale.py
  • in general check read.py and eventually port the useful elements
  • in general check write.py and eventually port the useful elements
  • main.py (which adds cli support)
  • restore links to the docs in the raedme

@LucaMarconato LucaMarconato changed the title enough features for the first applications (wip) legacy code to port Jan 30, 2023
@LucaMarconato LucaMarconato mentioned this pull request Feb 13, 2023
@LucaMarconato LucaMarconato deleted the feature/transform_and_coord_spaces branch February 22, 2023 21:23
@LucaMarconato
Copy link
Member Author

The code of this branch is archived here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants