Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressBook: remove master tag list #383

Closed
yamidark opened this issue Aug 5, 2018 · 1 comment
Closed

AddressBook: remove master tag list #383

yamidark opened this issue Aug 5, 2018 · 1 comment

Comments

@yamidark
Copy link
Contributor

yamidark commented Aug 5, 2018

We keep track of a master tag list which holds all the tags in
AddressBook.

As the master tag list was deemed unnecessary and may be too
complex for new developers to grasp, as discussed in
se-edu/addressbook-level4#753 and se-edu/addressbook-level4#794,
the master tag list has already been removed in AB4
by se-edu/addressbook-level4#824. As such, the master tag list
should also be removed for the lower level projects.

Let's remove the master tag list in AddressBook.

@damithc
Copy link
Contributor

damithc commented Aug 5, 2018

@yamidark IIRC, It is possible to link to issues across repos. e.g. se-edu/addressbook-level4#794

pyokagan added a commit that referenced this issue Aug 8, 2018
We keep track of a master tag list which holds all the tags in
AddressBook.

As the master tag list was deemed unnecessary and may be too
complex for new developers to grasp, as discussed in
se-edu/addressbook-level4#753 and se-edu/addressbook-level4#794,
the master tag list has already been removed in AB4
by se-edu/addressbook-level4#825.

UniqueTagList was also deemed unnecessary and removed in
addressbook-level4 after the master tag list is removed.

As such, the master tag list and UniqueTagList class should also be
removed in the lower level projects.

Let's remove the master tag list in AddressBook and AdaptedAddressBook,
as well as the UniqueTagList class.

  [1/3] AddressBook: remove master tag list
  [2/3] Remove UniqueTagList class
  [3/3] docs: update component on UniqueTagList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants