Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JAXB with AB1 Storage code #384

Closed
yamidark opened this issue Aug 5, 2018 · 0 comments
Closed

Replace JAXB with AB1 Storage code #384

yamidark opened this issue Aug 5, 2018 · 0 comments

Comments

@yamidark
Copy link
Contributor

yamidark commented Aug 5, 2018

Depends on #383

We are trying to ensure Java 9 compatibility for the project.

However, the project uses java.xml.bind module, which is marked as
deprecated in Java 9.

As discussed here, using deprecated modules is bad practice, thus we should switch to another method for storage purposes.

As discussed here, let's reuse the AB1 storage code for the AB2 project.

Zhiyuan-Amos added a commit that referenced this issue Aug 9, 2018
Storage uses the JAXB module for storing and retrieving of the
address book data in a file.

However, we are trying to ensure Java 9 compatibility in #381,
but the JAXB module is deprecated from Java 9 onwards.

As use of deprecated modules is considered bad practice, we should
replace our storage needs with another library before moving on
to ensure Java 9 compatibility.

As suggested here[1], let's reuse the storage code from
addressbook-level1.

[1]: #382 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant