Avoid subprocess when SKIPIF triggers IO #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
skipif-io
branch
2 times, most recently
from
7444297 to
258d3c7
Compare
staabm
commented
Nov 1, 2024
Comment on lines
+24
to
+27
| Child Process Started | ||
| Child Process Finished | ||
| Child Process Started | ||
| Child Process Finished |
There was a problem hiding this comment.
require + test-itself is running in subprocess
staabm
commented
Nov 1, 2024
Comment on lines
+24
to
+25
| Child Process Started | ||
| Child Process Finished |
There was a problem hiding this comment.
only the test itself is running in subprocess. skipif subprocess avoided.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 11.5 #6022 +/- ##
=========================================
Coverage 94.79% 94.79%
+ Complexity 6829 6824 -5
=========================================
Files 722 722
Lines 21681 21669 -12
=========================================
- Hits 20553 20542 -11
+ Misses 1128 1127 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that since we already separate include/require from other IO functions, we can run tests which only do IO (like for filesystem cleanup stuff) in the main process (like we already do for
--CLEAN--).followup to #5998, #5999