Add keystroke event support and allow adding text lines to the line editor #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-goodspeed
suggested changes
Mar 26, 2024
| @@ -74,5 +64,3 @@ function process_events(waitfor) | |||
| end | |||
|
|
|||
| coro.launch(process_events, catch_events) | |||
There was a problem hiding this comment.
Use fiber.launch() now, and pass a name. LuaState::expr() now detects if a script has imported fiber.lua, directly or indirectly, and if so it follows up with an implicit fiber.run() call that runs launched coroutines to completion. But fiber.run() only knows about coroutines launched with fiber.launch().
| @@ -71,4 +61,3 @@ function process_events(waitfor) | |||
| end | |||
|
|
|||
| coro.launch(process_events, catch_events) | |||
There was a problem hiding this comment.
same comment about fiber.launch()
nat-goodspeed
approved these changes
Mar 26, 2024
| @@ -2,6 +2,7 @@ XML_FILE_PATH = "luafloater_demo.xml" | |||
|
|
|||
| leap = require 'leap' | |||
| coro = require 'coro' | |||
There was a problem hiding this comment.
At this point you could ditch require 'coro' too.
| @@ -2,6 +2,7 @@ XML_FILE_PATH = "luafloater_gesture_list.xml" | |||
|
|
|||
| leap = require 'leap' | |||
| coro = require 'coro' | |||
There was a problem hiding this comment.
require 'coro' no longer needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script can be signed for 'keystroke' event now.
Added the command for appending text line (text editor) from the script.
Script updates:
Removed
util.containswhich is the same astable.findin luau;call leap.request() from LUA main thread.