-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keystroke event support and allow adding text lines to the line editor #1040
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41e14d3
Add keystroke event support and allow adding text lines to the line e…
maxim-productengine 7f39a5b
mac build fix
maxim-productengine 6d3226e
Merge branch 'release/luau-scripting' into lua-keystroke
maxim-productengine 6cedaec
Update test scripts to call leap.request() from main thread
maxim-productengine 24a7842
update scripts to use fiber.launch()
maxim-productengine 7a22e15
Merge branch 'release/luau-scripting' into luau-keystroke
maxim-productengine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ XML_FILE_PATH = "luafloater_gesture_list.xml" | |
|
||
leap = require 'leap' | ||
coro = require 'coro' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
fiber = require 'fiber' | ||
LLGesture = require 'LLGesture' | ||
|
||
--event pump for sending actions to the floater | ||
|
@@ -60,4 +61,4 @@ function process_events(waitfor) | |
end | ||
end | ||
|
||
coro.launch(process_events, catch_events) | ||
fiber.launch("catch_events", process_events, catch_events) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point you could ditch
require 'coro'
too.