Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #130

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Version Packages #130

merged 1 commit into from
Jul 28, 2023

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Jul 28, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@crackle/[email protected]

Minor Changes

  • #128 433a30f Thanks @mrm007! - Crackle now supports importing external CSS.

    This is useful when consuming packages which come with their own CSS, such as Pure React Carousel.

    External CSS can be imported with a side-effect import, same as how you would import a JavaScript or TypeScript module:

    // src/components/MyComponent.tsx
    import 'package-with-styles/dist/styles.css';
    
    import { Component } from 'package-with-styles';
    
    export const MyComponent = (props) => {
      <Component {...props} />;
    };

    The side-effect import will be preserved in the output bundles.

    External CSS can also be imported with a CSS @import rule:

    /* src/components/MyComponent/third-party.css */
    @import 'package-with-styles/dist/styles.css';
    // src/components/MyComponent.tsx
    import './third-party.css';
    
    export const MyComponent = () => {
      // ...
    };

    When importing with a CSS @import rule, Crackle will bundle all external CSS into one file and output it to the dist directory.
    Package exports will also be updated so consumers can import the bundled CSS.

  • #127 f52495d Thanks @mrm007! - Update dependencies

Patch Changes

  • #129 2b57d2f Thanks @mrm007! - Correctly resolve module exports when running crackle dev

    This fixes an issue where crackle dev would not resolve an entry's exports when the entry re-exported from another module using export * from ... syntax.

@crackle/[email protected]

Patch Changes

@seek-oss-ci seek-oss-ci requested a review from a team as a code owner July 28, 2023 00:16
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch from 09c4589 to e7d639a Compare July 28, 2023 03:51
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch from e7d639a to 4a710e2 Compare July 28, 2023 04:00
@mrm007 mrm007 enabled auto-merge (squash) July 28, 2023 04:01
@mrm007 mrm007 merged commit 891b6ce into master Jul 28, 2023
@mrm007 mrm007 deleted the changeset-release/master branch July 28, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants