Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Mail Helper Refactor #769

Merged
merged 65 commits into from
Apr 3, 2019
Merged

Python Mail Helper Refactor #769

merged 65 commits into from
Apr 3, 2019

Conversation

thinkingserious
Copy link
Contributor

Fixes #347

thinkingserious and others added 30 commits June 26, 2018 11:36
@thinkingserious
Initial working version of Send a Single Email to a Single Recipient
e07db8d
@thinkingserious
Code cleanup for first use case
6fb64da
@thinkingserious
Integrate PR #486
4ee2dd6
@thinkingserious
Integrate PR #458
3b705ed
@thinkingserious
Integrate PR #493
7ed4338
@thinkingserious
Add PR #496
6c23204
@thinkingserious
Formatting
2ee538f
@thinkingserious
Don't forget to thank previous PRs
56a0ad0
@thinkingserious
Merge branch 'master' of https://github.com/sendgrid/sendgrid-python …
ad6c4da 
…into v4
@thinkingserious
WIP
ff555ca
@hugovk
Drop support for EOL Python
79ec255
@hugovk
Upgrade Python syntax with pyupgrade
7da6749
@hugovk
Upgrade unit tests to use more useful asserts
76df67e
@hugovk
Fix flake8 and code inspections
3b01e12
@cmccandless
Quote names containing comma or semicolon
164c08a
@cmccandless
add explanatory comment
d53d193
@cmccandless
Add test for comma in name
0042b7b
@cmccandless
Add quotes around expected value in new test
32183b7
@rahulkumaran
Update requirements.txt
e4f1097
@thinkingserious
Merge pull request #626 from hugovk/v4-rm-eol
ae378dc 
v4: Drop support for EOL Python 2.6 and 3.0-3.3
@thinkingserious
Merge pull request #618 from cmccandless/issue-578
6326325 
Quote names containing comma or semicolon
@hugovk
Add support for Python 3.7
91a234c
@thinkingserious
Merge pull request #630 from rahulkumaran/update-requirements.txt
33a3576 
Update requirements.txt
@StrikerRUS
converted README and version as plain text
5fc2fa4
@StrikerRUS
updated Python versions in README from v4 branch
6807e5c
@StrikerRUS
hotfix for excess import
3debda7
@cmccandless
Allow creation of Mail from EmailMessage
03564f7
@cmccandless
Python2.7 import compatibility fix
8e4e721
@thinkingserious
Merge pull request #637 from hugovk/add-3.7-to-v4
63b8134 
v4: Add support for Python 3.7
@StrikerRUS
Merge remote-tracking branch 'upstream/v4' into pypi_v4
0dd1c3a
thinkingserious and others added 18 commits November 27, 2018 12:00
@thinkingserious
Add properies to mail.py
ee058df
@thinkingserious
Finished updating properties
9655794
@thinkingserious
Send a Single Email to a Single Recipient
0026089
@thinkingserious
Added Send a Single Email to Multiple Recipients Use Case
284ebaa
@thinkingserious
Merge pull request #665 from cmccandless/issue-354
0282aab 
Add use case for generation of Plain Text Content from HTML
@thinkingserious
Send Multiple Emails to Multiple Recipients
39acf5f
@thinkingserious
Merge branch 'v4' of https://github.com/sendgrid/sendgrid-python into v4
c417c31
@thinkingserious
WIP - final use case update, kitchen sink
43fc638
@thinkingserious
Merge pull request #655 from ChatPion/patch-1
f17f5d8 
Update USAGE.md
@thinkingserious
Merge pull request #666 from jaykay12/first-timer-documentation
19bb394 
Created First-timers.md File
@thinkingserious
kitchen sink example
72654f7
@thinkingserious
kitchen sink example
74ec42c
@thinkingserious
Testing everything but the kitchen sink
557378b
@thinkingserious
Add kitchen sink test
e6cf967
@thinkingserious
Prep for review
c97ec64
@thinkingserious
Rolling up diverging changes from master branch
3877a8f
@thinkingserious
Updated documentation
a945dcf
@thinkingserious
pep8
2fd6290
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: very hard fix is very hard in difficulty type: getting started question while getting started labels Apr 2, 2019
@thinkingserious thinkingserious self-assigned this Apr 2, 2019
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #769 into master will decrease coverage by 10.04%.
The diff coverage is 70.03%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #769       +/-   ##
=========================================
- Coverage   85.04%    75%   -10.05%     
=========================================
  Files          35     69       +34     
  Lines        1157   2012      +855     
  Branches      172    338      +166     
=========================================
+ Hits          984   1509      +525     
- Misses         90    322      +232     
- Partials       83    181       +98
Impacted Files Coverage Δ
sendgrid/helpers/endpoints/ip/unassigned.py 0% <0%> (-15%) ⬇️
sendgrid/helpers/mail/__init__.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/mime_type.py 100% <100%> (ø)
sendgrid/helpers/mail/header.py 89.28% <100%> (+3.57%) ⬆️
sendgrid/helpers/inbound/config.py 94.11% <100%> (-2.95%) ⬇️
sendgrid/helpers/mail/cc_email.py 100% <100%> (ø)
sendgrid/helpers/mail/to_email.py 100% <100%> (ø)
sendgrid/helpers/mail/bcc_email.py 100% <100%> (ø)
sendgrid/helpers/inbound/send.py 93.75% <100%> (ø) ⬆️
sendgrid/helpers/mail/from_email.py 100% <100%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b984...2fd6290. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #769 into master will decrease coverage by 9.2%.
The diff coverage is 71.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   85.04%   75.84%   -9.21%     
==========================================
  Files          35       69      +34     
  Lines        1157     2012     +855     
  Branches      172      338     +166     
==========================================
+ Hits          984     1526     +542     
- Misses         90      307     +217     
- Partials       83      179      +96
Impacted Files Coverage Δ
sendgrid/helpers/mail/__init__.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/mime_type.py 100% <100%> (ø)
sendgrid/helpers/mail/header.py 89.28% <100%> (+3.57%) ⬆️
sendgrid/helpers/inbound/config.py 94.11% <100%> (-2.95%) ⬇️
sendgrid/helpers/mail/cc_email.py 100% <100%> (ø)
sendgrid/helpers/mail/to_email.py 100% <100%> (ø)
sendgrid/helpers/mail/bcc_email.py 100% <100%> (ø)
sendgrid/helpers/inbound/send.py 93.75% <100%> (ø) ⬆️
sendgrid/helpers/mail/from_email.py 100% <100%> (ø)
sendgrid/helpers/mail/ganalytics.py 96.07% <100%> (+0.16%) ⬆️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b984...ae4b1fe. Read the comment docs.

@thinkingserious thinkingserious merged commit ae4b1fe into master Apr 3, 2019
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

This was referenced Apr 4, 2019
Closed
Closed
@childish-sambino childish-sambino mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thinkingserious thinkingserious

Labels
difficulty: very hard fix is very hard in difficulty status: code review request requesting a community code review or review from Twilio type: getting started question while getting started
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@thinkingserious @ashb @hugovk @cmccandless @rahulkumaran @StrikerRUS @jaykay12 @chatpion