Remove sensu::backend username and password parameters #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
sensu2-password
branch
2 times, most recently
from
e8a268a to
3623bce
Compare
ghoneycutt
reviewed
Oct 29, 2018
ghoneycutt
reviewed
Oct 29, 2018
treydock
force-pushed
the
sensu2-password
branch
from
3623bce to
efe8073
Compare
Merged
treydock
force-pushed
the
sensu2-password
branch
from
efe8073 to
b2a575e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Remove
usernameandpasswordparameters fromsensu::backend. Document limitation.Related Issue
Part of #901
Motivation and Context
Changing either of these parameters would break the bootstrap of sensuctl. These options will be added back once upstream supports better management of users which will allow this module to properly manage user resources.