Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Support sensu-go #901

Closed
36 of 41 tasks
ghoneycutt opened this issue May 3, 2018 · 22 comments · Fixed by #1077
Closed
36 of 41 tasks

v3 - Support sensu-go #901

ghoneycutt opened this issue May 3, 2018 · 22 comments · Fixed by #1077
Labels

Comments

@ghoneycutt
Copy link
Collaborator

ghoneycutt commented May 3, 2018

What's needed to support sensu-go

For an item to be checked, it needs the following if applicable.

  • spec tests
  • acceptance tests (beaker/serverspec)
  • Vagrant instance for each platform
@treydock
Copy link
Collaborator

@ghoneycutt Where is environment documented? Also may not need to do anything for event, looks like entirely informational and nothing that can be changed with sensuctl.

@treydock
Copy link
Collaborator

@ghoneycutt Nevermind about environment, found under RBAC section.

@treydock
Copy link
Collaborator

treydock commented Jun 9, 2018

@ghoneycutt Any references for extension? Also do we want to add a type for event? event seems like something sent by checks or on a more ad-hoc basis.

@ghoneycutt
Copy link
Collaborator Author

I think extension is just for v1 of sensu as it is not listed in the v2 docs

@ghoneycutt
Copy link
Collaborator Author

@treydock Event's can be deleted and resolved, so we should have a type/provider for them.

@treydock
Copy link
Collaborator

@ghoneycutt Can check off EL6 and Ubuntu 14.04. The tests for Ubuntu 18.04 work in Docker and Vagrant is fixed with #915.

@treydock
Copy link
Collaborator

@ghoneycutt For the config type, the only things it can change in sensuctl is default organization, environment and output format. AFAICT our use of sensuctl create -f bypasses default organization and environment so those are defaulted in the individual types.

I do notice that right now if a system in provisioned and the password changed later, sensuctl configure won't get re-run.

@ghoneycutt
Copy link
Collaborator Author

@treydock Added documentation with puppet-strings to the list.

https://puppet.com/docs/puppet/5.5/puppet_strings_style.html#resource-types

@treydock
Copy link
Collaborator

May need to add extension back, it appears to be something that can be managed with sensuctl.

@ghoneycutt
Copy link
Collaborator Author

Put it back on the list.

@treydock
Copy link
Collaborator

treydock commented Jul 6, 2018

@ghoneycutt Issue with el6 in Vagrant appears to be fact box doesn't ship with latest kernel and when the guest addition logic adds kernel-headers it adds the latest available kernel headers and not the ones for kernel running on the box. Logging into the box, updating kernel, and reloading fixes the box.

The issue with Ubuntu 14.04 box is issue with Vagrantfile I've opened PR #934

@treydock
Copy link
Collaborator

treydock commented Jul 6, 2018

@ghoneycutt Need a checkbox to add ensure => absent support to sensu_asset. This is opened here: sensu/sensu-go#988

@treydock
Copy link
Collaborator

sensu-go appears to be adding cli support to manage backend cluster members. Should probably add checkbox for cluster management.

@treydock
Copy link
Collaborator

treydock commented Aug 7, 2018

@ghoneycutt config can be checked off via #938. Need a checkbox to add ensure => absent support to sensu_asset. This is opened here: sensu/sensu-go#988. The provider for sensu_asset supports delete but it causes errors when invoked, the acceptance tests explicitly skip testing the deletion of assets. Only change necessary for sensu_asset is removing the skip here: https://github.com/sensu/sensu-puppet/blob/sensu2/spec/acceptance/sensu_asset_spec.rb#L54

@treydock
Copy link
Collaborator

@ghoneycutt Can check off extension provider code is cleaned up via #1013 .

@treydock
Copy link
Collaborator

@ghoneycutt User type is done but lacks ensure => absent similar to assets: sensu/sensu-go#2540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants