update rabbitmq default port #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed that 1.0 was already released, this is a breaking change though since it changes default params. |
jlambert121
added a commit
that referenced
this pull request
Jan 31, 2014
update rabbitmq default port
| @@ -28,7 +28,7 @@ def initialize(*args) | |||
| newproperty(:port) do | |||
| desc "The port that the Sensu Dashboard should listen on" | |||
|
|
|||
| defaultto '5671' | |||
| defaultto '5672' | |||
There was a problem hiding this comment.
Shouldn't this be 8080 or some such? It's not the rabbitmq port, it's the dashboard port...
There was a problem hiding this comment.
It should. The default here (probably) isn't being used by anyone since it is being passed from the init.pp, but should still be updated.
https://github.com/sensu/sensu-puppet/blob/master/manifests/init.pp#L195
There was a problem hiding this comment.
Resolved with #149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.