Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rabbitmq default port #147

Merged
merged 1 commit into from
Jan 31, 2014
Merged

update rabbitmq default port #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/type/sensu_dashboard_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def initialize(*args)
newproperty(:port) do
desc "The port that the Sensu Dashboard should listen on"

defaultto '5671'
defaultto '5672'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 8080 or some such? It's not the rabbitmq port, it's the dashboard port...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. The default here (probably) isn't being used by anyone since it is being passed from the init.pp, but should still be updated.

https://github.com/sensu/sensu-puppet/blob/master/manifests/init.pp#L195

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved with #149

end

newproperty(:host) do
Expand Down
2 changes: 1 addition & 1 deletion lib/puppet/type/sensu_rabbitmq_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def initialize(*args)
newproperty(:port) do
desc "The port that RabbitMQ is listening on"

defaultto '5671'
defaultto '5672'
end

newproperty(:host) do
Expand Down
4 changes: 2 additions & 2 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
#
# [*rabbitmq_port*]
# Integer. Rabbitmq port to be used by sensu
# Default: 5671
# Default: 5672
#
# [*rabbitmq_host*]
# String. Host running rabbitmq for sensu
Expand Down Expand Up @@ -178,7 +178,7 @@
$dashboard = false,
$manage_services = true,
$manage_user = true,
$rabbitmq_port = 5671,
$rabbitmq_port = 5672,
$rabbitmq_host = 'localhost',
$rabbitmq_user = 'sensu',
$rabbitmq_password = '',
Expand Down