Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chocolaty package manager on Windows #664

Closed
wants to merge 1 commit into from

Conversation

jpuskar
Copy link

@jpuskar jpuskar commented Jun 15, 2017

Windows package support for non-default providers and titles.

@jpuskar jpuskar force-pushed the 2_2_1_windows_pkg_fixes branch from 44bb3d8 to 82978fd Compare June 15, 2017 16:17
@jpuskar jpuskar force-pushed the 2_2_1_windows_pkg_fixes branch from 82978fd to 3467077 Compare June 15, 2017 16:25
@jeffmccune jeffmccune changed the title Implemented fix for https://github.com/sensu/sensu-puppet/issues/589. [WIP] Add support for Chocolatey package manager on Windows Jul 8, 2017
@jeffmccune jeffmccune changed the title [WIP] Add support for Chocolatey package manager on Windows Add support for Chocolaty package manager on Windows Jul 8, 2017
@jeffmccune
Copy link
Collaborator

Resolves #589

jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this pull request Jul 8, 2017
Without this patch package resource used to install sensu on Windows defaults
to the `msi` provider and can't easily be changed to the Chocolatey provider.
This patch addresses the problem by adding a new class parameter,
`sensu::windows_package_provider` which defaults to `undef`, the default
behavior of Puppet on windows, and can be set to `'chocolatey'`.

Closes sensu#664
Resolves sensu#589

Original Author: john.puskar <[email protected]>
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this pull request Jul 8, 2017
Without this patch package resource used to install sensu on Windows defaults
to the `msi` provider and can't easily be changed to the Chocolatey provider.
This patch addresses the problem by adding a new class parameter,
`sensu::windows_package_provider` which defaults to `undef`, the default
behavior of Puppet on windows, and can be set to `'chocolatey'`.

Closes sensu#664
Resolves sensu#589

Original Author: john.puskar <[email protected]>

The chocolatey package provider may be exercised with `vagrant up
win2012r2-client-chocolatey`.  There is no `senu` package in the public
chocolatey repository, however, so installation will fail with the following error:

    ==> win2012r2-client-chocolatey: Error: Execution of 'C:\ProgramData\chocolatey\bin\choco.exe install sensu -y ' returned 1: Ch
    ocolatey v0.10.7
    ==> win2012r2-client-chocolatey: Installing the following packages:
    ==> win2012r2-client-chocolatey: sensu
    ==> win2012r2-client-chocolatey: By installing you accept licenses for the packages.
    ==> win2012r2-client-chocolatey: sensu not installed. The package was not found with the source(s) listed.
    ==> win2012r2-client-chocolatey:  If you specified a particular version and are receiving this message, it is possible that the
     package name exists but the version does not.
    ==> win2012r2-client-chocolatey:  Version: ""
    ==> win2012r2-client-chocolatey:  Source(s): "https://chocolatey.org/api/v2/"
    ==> win2012r2-client-chocolatey: Chocolatey installed 0/1 packages. 1 packages failed.
    ==> win2012r2-client-chocolatey:  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Even with this error, the behavior of the chocolatey package provider is
exercised.
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this pull request Jul 8, 2017
Without this patch package resource used to install sensu on Windows defaults
to the `msi` provider and can't easily be changed to the Chocolatey provider.
This patch addresses the problem by adding a new class parameter,
`sensu::windows_package_provider` which defaults to `undef`, the default
behavior of Puppet on windows, and can be set to `'chocolatey'`.

Closes sensu#664
Resolves sensu#589

Original Author: john.puskar <[email protected]>

The chocolatey package provider may be exercised with `vagrant up
win2012r2-client-chocolatey`.  There is no `senu` package in the public
chocolatey repository, however, so installation will fail with the following error:

    ==> win2012r2-client-chocolatey: Error: Execution of 'C:\ProgramData\chocolatey\bin\choco.exe install sensu -y ' returned 1: Ch
    ocolatey v0.10.7
    ==> win2012r2-client-chocolatey: Installing the following packages:
    ==> win2012r2-client-chocolatey: sensu
    ==> win2012r2-client-chocolatey: By installing you accept licenses for the packages.
    ==> win2012r2-client-chocolatey: sensu not installed. The package was not found with the source(s) listed.
    ==> win2012r2-client-chocolatey:  If you specified a particular version and are receiving this message, it is possible that the
     package name exists but the version does not.
    ==> win2012r2-client-chocolatey:  Version: ""
    ==> win2012r2-client-chocolatey:  Source(s): "https://chocolatey.org/api/v2/"
    ==> win2012r2-client-chocolatey: Chocolatey installed 0/1 packages. 1 packages failed.
    ==> win2012r2-client-chocolatey:  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Even with this error, the behavior of the chocolatey package provider is
exercised.
@ghoneycutt
Copy link
Collaborator

Released in v2.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants