(#589) Add Chocolatey support for Windows #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch package resource used to install sensu on Windows defaults to the `msi` provider and can't easily be changed to the Chocolatey provider. This patch addresses the problem by adding a new class parameter, `sensu::windows_package_provider` which defaults to `undef`, the default behavior of Puppet on windows, and can be set to `'chocolatey'`. Closes sensu#664 Resolves sensu#589 Original Author: john.puskar <[email protected]> The chocolatey package provider may be exercised with `vagrant up win2012r2-client-chocolatey`. There is no `senu` package in the public chocolatey repository, however, so installation will fail with the following error: ==> win2012r2-client-chocolatey: Error: Execution of 'C:\ProgramData\chocolatey\bin\choco.exe install sensu -y ' returned 1: Ch ocolatey v0.10.7 ==> win2012r2-client-chocolatey: Installing the following packages: ==> win2012r2-client-chocolatey: sensu ==> win2012r2-client-chocolatey: By installing you accept licenses for the packages. ==> win2012r2-client-chocolatey: sensu not installed. The package was not found with the source(s) listed. ==> win2012r2-client-chocolatey: If you specified a particular version and are receiving this message, it is possible that the package name exists but the version does not. ==> win2012r2-client-chocolatey: Version: "" ==> win2012r2-client-chocolatey: Source(s): "https://chocolatey.org/api/v2/" ==> win2012r2-client-chocolatey: Chocolatey installed 0/1 packages. 1 packages failed. ==> win2012r2-client-chocolatey: See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log). Even with this error, the behavior of the chocolatey package provider is exercised.
ghoneycutt
approved these changes
Jul 8, 2017
|
Released in v2.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch package resource used to install sensu on Windows defaults
to the
msiprovider and can't easily be changed to the Chocolatey provider.This patch addresses the problem by adding a new class parameter,
sensu::windows_package_providerwhich defaults toundef, the defaultbehavior of Puppet on windows, and can be set to
'chocolatey'.The chocolatey package provider may be exercised with
vagrant up win2012r2-client-chocolatey. There is nosensupackage in the publicchocolatey repository, however, so installation will fail with the following error:
Even with this error, the behavior of the chocolatey package provider is
exercised.
Closes #664
Resolves #589
Original Author: john.puskar [email protected]