Sensu2 strings docs #925
Merged
Sensu2 strings docs #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Came across this some time ago: https://groups.google.com/d/msg/puppet-users/W2Vv4vrvOcY/N6KMkq3WDAAJ. The site puppetmodule.info that hosts puppet strings output. Also, 4 properties in sensu_check are undocumented because they exist in Go but not on sensu documentation website. I wanted the description to match documentation, should we file a bug with sensu-docs repo? |
|
Good catch! We should match the documentation. If the documentation is not accurate to the code, please do file bugs. |
ghoneycutt
approved these changes
Jun 27, 2018
|
Two of the acceptance tests timed out, else they were are good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Ensure all classes and types have documentation that is compatible with Puppet strings.
Also some minor cleanup of commented out code in sensu_check.
Related Issue
Relates to #901
Motivation and Context
All classes and types should have proper documentation.
How Has This Been Tested?
bundle exec rake strings:generate- the only warnings are unused code that is removed in #924General
New parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec