Sensu2 docs #932
Merged
Sensu2 docs #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
sensu2-docs
branch
2 times, most recently
from
765b24b to
761f589
Compare
|
@ghoneycutt Let me know if squash is necessary. #944 needed for tests to pass. |
* Add some additional examples * Use consistent puppet-strings doc format * Remove defaults as puppet-strings will show defaults Cleanup commented code
|
@ghoneycutt squashed and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Documentation improvements.
Related Issue
Relates to #901
Motivation and Context
Wanted to provide some better examples for classes as well as types that have complex properties or composite name support. Also removed defaults from puppet-strings inline documentation as puppet-strings will read defaults from module code and wanted to remove duplicate default output.
How Has This Been Tested?
bundle exec rake strings:generateGeneral
New parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec