Use exact dependencies on other serde crates #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [dev-dependencies] | ||
| clippy = "^0.*" | ||
| compiletest_rs = "^0.2.0" | ||
| fnv = "1.0" | ||
| rustc-serialize = "^0.3.16" | ||
| serde = "0.8.0" | ||
| serde_test = "0.8.0" | ||
| serde = "=0.8.0" |
There was a problem hiding this comment.
No I guess not - I just changed every dependency of a serde crate on a different serde crate. We should be okay constraining just serde_macros->serde_codegen and serde_codegen->serde_codegen_internals.
|
I think this is the correct solution. Serde_macros is so finnicky, technically it should require major version bumps of serde_codegen whenever it's adjusted for a new nightly |
|
@oli-obk opinion on constraining all or just those two dependencies? I think constraining just serde_macros->serde_codegen and serde_codegen->serde_codegen_internals is less likely to cause trouble. |
|
Yea, there's no point in restricting the serde version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@azerupi @oli-obk @erickt do you think this would fix the problem in #470? Are there other problems it could cause?
When compiling an old serde_macros this prevents it from depending on a new serde_codegen which may be on an incompatible quasi version.