Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a thread in the build script of serde_codegen to allow env vars to control the stack size #488

Merged
merged 2 commits into from
Aug 11, 2016
Merged

use a thread in the build script of serde_codegen to allow env vars to control the stack size #488

merged 2 commits into from
Aug 11, 2016

Conversation

oli-obk
Copy link
Member

@oli-obk oli-obk commented Aug 9, 2016

cc #486

@oli-obk
Copy link
Member Author

oli-obk commented Aug 9, 2016

the .cargo/config overwrites don't seem to work as well as the path dependencies

@dtolnay
Copy link
Member

dtolnay commented Aug 10, 2016

LGTM. The .cargo/config worked until #472 - I guess we go back to a path dependency for the serde_macros->serde_codegen dependency, or fix it in Cargo.

@oli-obk
Copy link
Member Author

oli-obk commented Aug 11, 2016

skeptic has some issues with finding libs on nightly... I don't have time for it now, so I'm merging as is, since everything else passed

@oli-obk oli-obk merged commit f59ec44 into serde-rs:master Aug 11, 2016
@oli-obk oli-obk deleted the codegen_stack_overflow_hack branch August 11, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @dtolnay