Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key error is raised if key 'sharding' doesn't exist #472

Closed
SridharJagannathan opened this issue May 27, 2021 · 2 comments
Closed

Key error is raised if key 'sharding' doesn't exist #472

SridharJagannathan opened this issue May 27, 2021 · 2 comments

Comments

@SridharJagannathan
Copy link
Contributor

cloud-volume/cloudvolume/datasource/precomputed/skeleton/metadata.py

Line 88 in 5db65a9

del info["sharding"]

In the above line, if the key 'sharding' did not exist in the first place it produces the following error:

KeyError: 'sharding'
SridharJagannathan added a commit to SridharJagannathan/cloud-volume that referenced this issue May 27, 2021
@SridharJagannathan
updated for seung-lab#472
6207c89
@SridharJagannathan
Copy link
Contributor Author

@william-silversmith Please feel free to merge the PR #473 to resolve this issue. I noticed this error while running test cases for my python package: https://github.com/SridharJagannathan/pyroglancer

william-silversmith pushed a commit that referenced this issue May 27, 2021
@SridharJagannathan
fix: delete "sharding" if None w/o KeyError #472 (#473)
a9c38b1
@william-silversmith
Copy link
Contributor

Thanks! I just merged your change and it'll go out in the next release.

william-silversmith pushed a commit that referenced this issue Jun 8, 2021
@SridharJagannathan
Implementation for sharded multi res mesh generation with offsets (#477)
32a49ed 
* updated for #472

* implementation for sharded mutires mesh generation

* fixed testcase error, doc updates

* modified variable name after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@william-silversmith @SridharJagannathan