Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for sharded multi res mesh generation with offsets #477

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

SridharJagannathan
Copy link
Contributor

Implemented for solving:
#475

@SridharJagannathan
Copy link
Contributor Author

SridharJagannathan commented Jun 8, 2021

In principle this seems to work.
I have just made multi res meshes of the antenna lobe (left, right) in the sharded format.
I need to just solve the test error and some docs now..

Screenshot 2021-06-08 at 12 49 17

Screenshot 2021-06-08 at 12 58 18

@william-silversmith
Copy link
Contributor

This looks great! Just one style point, would you mind changing dataoffset to data_offset? Other than that, I'm ready to merge.

@SridharJagannathan
Copy link
Contributor Author

Done!

@william-silversmith
Copy link
Contributor

Thank you so much! When you've finished your multi-res code, would there be a public place where I could take a look? Merging.

@william-silversmith william-silversmith merged commit 32a49ed into seung-lab:master Jun 8, 2021
@william-silversmith william-silversmith added meshes Pertains to mesh objects or IO services. sharding Pertains to the sharded format. labels Jun 8, 2021
@william-silversmith william-silversmith self-requested a review June 8, 2021 18:01
@SridharJagannathan
Copy link
Contributor Author

@william-silversmith: The implementation is composed of two parts:

  1. The mutli-res mesh generation is here: https://github.com/SridharJagannathan/pyroglancer/blob/master/pyroglancer/meshgenerator.py
    this was based on the discussions in a neuroglancer thread a while ago, which i adapted a bit.
  2. The binary file generation for multi-res sharded is here:
    https://github.com/SridharJagannathan/pyroglancer/blob/master/pyroglancer/volumes.py#L146
    Hope it is helpful for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meshes Pertains to mesh objects or IO services. sharding Pertains to the sharded format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating sharded multi resolution meshes
2 participants