Don't use VSTGUI::CNewFileSelector::setDefaultExtension #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcima
reviewed
Mar 10, 2021
plugins/editor/src/editor/Editor.cpp
Outdated
|
|
||
| // also add extensions of importable files | ||
| fs->addFileExtension(CFileExtension("SFZ", "sfz")); |
There was a problem hiding this comment.
SFZ is not among "importable files" as indicated in the comment.
Can you move it back up a few lines?
This fixes a wrong file extension filter in the file dialog under Windows. It seems that the last added extension is selected as default one due to some wrong selection index. So use the All Files filter as workaround.
redtide
force-pushed
the
windows-fileselector-default-filter
branch
from
b9325ed to
982116a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a wrong file extension filter in the file dialog under Windows.
It seems that the last added extension is selected as default one due to some wrong selection index. So use the All Files filter as workaround.