Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed timeout in python test (#169) and reduced CPU load while waiting #170

Merged

Conversation

guihomework
Copy link
Contributor

Proposed changes

Fixes #169 and additionally put some sleep to avoid high CPU load while waiting for parameters.

Test works now

[sr_utilities.rosunit-test_hand_finder_cpp/hand_absent_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/one_hand_no_robot_description_finder_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/one_hand_no_mapping_no_robot_description_finder_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/one_hand_no_prefix_no_robot_description_finder_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/one_hand_no_mapping_no_prefix_no_robot_description_finder_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/one_hand_robot_description_exists_finger_test][passed]
[sr_utilities.rosunit-test_hand_finder_cpp/two_hand_robot_description_exists_finder_test][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_no_hand_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_no_hand_robot_description_exists_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_mapping_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_mapping_robot_description_exists_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_prefix_no_mapping_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_prefix_no_ns_robot_description_exists_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_prefix_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_prefix_robot_description_exists_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_one_hand_robot_description_exists_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_two_hand_no_robot_description_finder][passed]
[sr_utilities.rosunit-test_hand_finder_py/test_two_hand_robot_description_exists_finder][passed]

SUMMARY
 * RESULT: SUCCESS
 * TESTS: 19
 * ERRORS: 0
 * FAILURES: 0

Checklist

If the task is applicable to this pull request (see applicability criteria in brackets), make sure it is completed before checking the corresponding box. Otherwise, tick the box right away. Make sure that ALL boxes are checked BEFORE the PR is merged.

  • Manually tested that added code works as intended (if any functional/runnable code is added).
  • Added automated tests (if a new class is added (Python or C++), interface of that class must be unit tested).
  • Tested on real hardware (if the changed or added code is used with the real hardware).
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc.)

@guihomework guihomework requested review from a team as code owners April 21, 2021 19:03
@mykolasjuraitis mykolasjuraitis merged commit 65e9866 into shadow-robot:melodic-devel Apr 22, 2021
@guihomework guihomework deleted the B#169_pythontest_timeout branch April 26, 2021 19:09
carebare47 added a commit that referenced this pull request May 13, 2022
* Fixed timeout in python test (#169) and reduced CPU load while waiting (#170)

* Fix#171 handfinder ns (#173)

* Fixing hand finders to support namespace

* Additional fix of the same namespace problem

* B#171 handfinder ns (#172)

* Fixing sr_utilities tests to handle namespaced tests

* Added namespaced test to sr_utilities

* Fixing J0 (J1 and J2) position and velocity filter

Co-authored-by: GuiHome <[email protected]>
Co-authored-by: Toni Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sr_utilities] broken test due to long timeout
3 participants