B#171 handfinder ns #172
Merged
B#171 handfinder ns #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giusebar
approved these changes
Apr 27, 2021
beatrizleon
approved these changes
Apr 27, 2021
|
Hi @guihomework. Thanks for doing these fixes! The other one has been merged, but this is failing. Might be because it needs the changes form the other one. Could you update this branch? |
|
@beatrizleon yes of course this one will fail without the fix, this is what the test was all about, being capable of finding the mistake and the fix makes the test pass again. what do you want me to change ? should I rebase on top of melodic-devel ? |
guihomework
force-pushed
the
B#171_handfinder_ns
branch
from
f19e74c to
f2a34e1
Compare
|
All green now. Thanks! |
carebare47
added a commit
that referenced
this pull request
May 13, 2022
* Fixed timeout in python test (#169) and reduced CPU load while waiting (#170) * Fix#171 handfinder ns (#173) * Fixing hand finders to support namespace * Additional fix of the same namespace problem * B#171 handfinder ns (#172) * Fixing sr_utilities tests to handle namespaced tests * Added namespaced test to sr_utilities * Fixing J0 (J1 and J2) position and velocity filter Co-authored-by: GuiHome <[email protected]> Co-authored-by: Toni Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds tests to find bug reported in #171 and remain compatible to convention
Checklist
If the task is applicable to this pull request (see applicability criteria in brackets), make sure it is completed before checking the corresponding box. Otherwise, tick the box right away. Make sure that ALL boxes are checked BEFORE the PR is merged.